Repository navigation
fix(search): preserve distinct nearby businesses - #438
Merged
Merged
Conversation
Collaborator
Author
|
Controlled fictional #429 REWE fixture in the actual local SearchBar, at Berlin [13.4, 52.52], zoom 15. Before: only Street A 1 survives. After: Street A 1 and Street B 2 (338 m apart) are separate choices; click/keyboard selection retains each original ID, address and coordinates. The API is a controlled stub with empty tiles, so this does not establish live provider coverage. Both cropped result-list screenshots were personally inspected; no review images are committed. Before
After
|
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Related issues
Fixes #429
#428 was completed by merged #432 before this work. This branch is rebased onto main
5f07b70967319b4b2c86769b542b551b93f98e02and changes only deduplication, its tests and documentation.How was this tested?
pnpm lint,pnpm check-types,pnpm check:policy,pnpm check-openapi, andpnpm -C docs buildpass on current main. Lint reports existing non-gating warnings. No API contract changes are included.pnpm test --maxWorkers=2 --hookTimeout=30000passes 17,426 tests / 1,530 files, with 135 tests / 28 files skipped by existing repository conditions. The initial default-concurrency run hit unchanged API setup/publisher timeouts; both suites passed an isolated rerun (81 tests). The final invocation adjusts local concurrency and hook headroom without changing repository configuration or skipping crypto. Publication uses a per-command hook override after these gates to avoid repeating the full suite with the known local 10-second setup deadline.Checklist
pr-titlecheck enforces this)pnpm lint && pnpm check-types && pnpm testpass locally — full test invocation and local timeout limitations recorded abovedocs/).envfiles committedReadable controlled before/after screenshots are attached directly to this PR; no review images are committed.