Repository navigation
fix(search): require complete business location evidence - #432
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MediaMarkt Alexapreviously treatedAlexain the remote street wordAlexanderas exact location intent. Require complete normalized address words for the exact upgrade, retaining weaker prefix autocomplete matches and existing score weights.Related issues
Fixes #428
How was this tested?
Friedrichstr.addresses; partial primary names; exact aliases/codes; station abbreviation and same-name proximity controls. Real SearchBar options use the fixture, independently remote-first forward results, plain Enter area fallback, ArrowDown + Enter selection and explicit remote-city Enter.pnpm lint,pnpm check-types(30 workspace tasks plus discovery-eval),pnpm check:policy,git diff --check, docs production build, andpnpm check-openapi(384 operations) passed.e9e7b7ed0: all CI checks passed, including 14,181 node tests, 3,630 web tests, mobile/database tests, lint, types, docs, production build, all six Docker builds, CodeQL, dependency review, title validation and CLA verification. The auto-merge and release-publication jobs were skipped as expected for this PR. Final self-review found no further changes needed; a fresh pre-merge run of the four search regression files passed all 160 tests with the unchanged repository configuration.Controlled browser evidence
The live hosted adapted autocomplete was re-read on 2026-10-07 and still returned Rijswijk first, Berlin second. Its six returned rows are the committed regression fixture, not raw MapTiler output. The actual local Next.js app replayed those responses through the unmodified hooks, SearchBar and dropdown. Forward geocoding also replayed the captured Rijswijk-first response. Final controls returned empty aggregate/brand/preset results. Camera
[13.416, 52.5194], zoom 15, English, 1280 × 800 viewport.MediaMarkt AlexaMediaMarkt Alexamaptiler:poi.15539884(Rijswijk)MediaMarkt Alexamaptiler:poi.15422100(Berlin)MediaMarkt Rijswijkmaptiler:poi.15539884(Rijswijk)Browser NLP was unavailable in the read-only fixture proxy, so its existing empty/error fallback reached area search. The automated plain-Enter regression also verifies the direct area path with AI search disabled. No NLP/provider completeness improvement is claimed. The local self-hosted tile endpoint
/tiles/data/openmapx.jsonreturned 404; the screenshots verify readable dropdown order and distance labels, not basemap rendering. Deployment revision and upstream/cache state are unknown; no deployment was changed.Screenshots
Same captured autocomplete fixture, query, camera and viewport. Personally inspected both; review images are GitHub attachments and are not committed.
Before:
After:
Checklist
pnpm lint && pnpm check-types && pnpm testpass locally — default full-suite timing limitations documented above; scoped regressions pass.envfiles or review images committed