Add algorithm selection to feature grouping and peak picking methods#19
Merged
Merged
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: timosachsenberg <5803621+timosachsenberg@users.noreply.github.com>
Co-authored-by: timosachsenberg <5803621+timosachsenberg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add option to choose algorithms and pass parameters
Add algorithm selection to feature grouping and peak picking methods
Nov 19, 2025
Contributor
|
@copilot test it if not already done and update readme |
Co-authored-by: timosachsenberg <5803621+timosachsenberg@users.noreply.github.com>
Contributor
Author
Tests completed successfully - all 83 tests pass. README updated with documentation for the new algorithm selection options in commit 2f42d7f. The documentation now covers:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Add Algorithm Selection Options to Hardcoded Methods
Problem Statement
The codebase had several methods with hardcoded algorithms. This PR adds flexibility to choose different algorithms while maintaining backward compatibility.
Changes Implemented
1. Feature Grouping Algorithms ✅
Files Modified:
openms_python/py_consensusmap.pyopenms_python/workflows.pyNew Functionality:
Py_ConsensusMap.align_and_link(): Addedgrouping_methodandgrouping_paramsparameterslink_features(): Addedgrouping_methodparameterExample Usage:
2. Peak Picking Algorithms ✅
Files Modified:
openms_python/py_msexperiment.pyNew Functionality:
Example Usage:
3. Documentation ✅
Files Modified:
README.mdUpdates:
Testing & Quality Assurance
Backward Compatibility
All changes are fully backward compatible:
Files Changed
openms_python/py_consensusmap.py(+39/-2)openms_python/py_msexperiment.py(+1)openms_python/workflows.py(+38/-3)tests/test_consensus_map.py(+42)tests/test_py_msexperiment.py(+12)tests/test_workflows.py(+47)README.md(+16/-4) - documentation updatesTotal: 190 insertions, 9 deletions
Security Summary
CodeQL security scan completed successfully with 0 alerts. No security vulnerabilities introduced.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.