Aeropropulsive scenario and docs update#175
Open
lamkina wants to merge 4 commits intoOpenMDAO:mainfrom
Open
Conversation
anilyil
reviewed
Jul 5, 2024
Collaborator
anilyil
left a comment
anilyil
left a comment
There was a problem hiding this comment.
Looks good overall. I have 2 minor comments
| Aeropropulsive Scenario | ||
| %%%%%%%%%%%%%%%%%%%%%%% | ||
|
|
||
| The :class: `ScenarioAeropropulsive <mphys.scenario_aeropropulsive.ScenarioAeropropulsive>` is for static coupled aerodynamic and propulsion problems. |
Collaborator
There was a problem hiding this comment.
What does the word "static" mean here? Did you want to mean "steady state" or something else?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a small change to the aeropropulsive scenario to make he builder names consistent with nomenclature in recent aeropropulsive literature as well as remove confusion with the OpenMDAO balance component. In addition, I added a brief documentation page for the aeropropulsive scenario.
The nomenclature change converts the
balance_builderto thebc_coupling_builderand removes it from the coupling group. This is because the standard practice for aeropropulsive problems is to let the optimizer handle the boundary condition coupling with consistency constraints using IDF architecture.Ideally, @ArshSaja and @anilyil should take a look at this PR as the other main users of the aeroprop scenario.