Repository navigation
Conversation
getDrive (used for storage capacity) was the only request that opted out of the InvalidAuthenticationToken refresh, so an expired token made the capacity query fail until another request happened to refresh it. Let it refresh like every other request. The retry after a refresh did not pass noRetry, so a token that stayed invalid after a successful refresh recursed without bound. Retry once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U5btuswaVrY7Lp7FWWVEHh
Author
|
@pikachuren @jyxjjj 这是从 #2950 拆分出来的 OneDrive 部分,方便时麻烦看一下,谢谢! |
16 of 25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
English
Two small fixes to the token refresh in the OneDrive and OneDrive APP drivers.
getDrive(used to report storage capacity) was the only request that passednoRetry, so it skipped theInvalidAuthenticationTokenrefresh. With an expired token, the capacity query failed until some other request happened to refresh the token. It now refreshes like every other request.noRetry, so a token that stayed invalid recursed without limit. The request is now retried at most once.No behavior change for requests that succeed, and no config or API change.
Split out of #2950.
中文
修复 OneDrive 和 OneDrive APP 驱动 token 刷新的两个小问题。
getDrive(用于获取存储容量)是唯一传了noRetry的请求,因此跳过了InvalidAuthenticationToken时的刷新。token 过期后,容量查询会一直失败,直到其他请求碰巧刷新了 token。现在它和其他请求一样会刷新 token。noRetry,如果 token 刷新后仍然无效,会无限递归。现在最多只重试一次。请求成功时行为不变,也没有配置或 API 变化。
从 #2950 中拆分出来。
/ 此 PR 包含破坏性变更。
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
/ 此 PR 需要关联仓库同步修改。
Related Issues / 关联 Issue
Relates to #2950
Testing / 测试
go test ./...English
go vetandgo buildpass fordrivers/onedriveanddrivers/onedrive_app. These packages have no unit tests, and the change was not tested against a live OneDrive account.中文
drivers/onedrive和drivers/onedrive_app的go vet、go build通过。这两个包没有单元测试,本次改动未在真实的 OneDrive 账号上测试。Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。
Note: The
getDrivechange first appeared in a Codex-authored commit on #2950. The bounded retry was added during review with Claude. This PR is a single commit that includesCo-Authored-By.说明:
getDrive的改动最早出现在 #2950 中一个由 Codex 生成的提交里;限制重试次数是在 Claude 辅助审查时加入的。本 PR 只有一个提交,带有Co-Authored-By。