feat(cache): add configurable HybridCache policies - #3075
Draft
vxtls wants to merge 1 commit into
Draft
Conversation
- Add auto, memory, and disk cache policies with global configuration and per-instance overrides. - Select the backing store in auto mode using the complete workload memory ceiling while preserving runtime disk spill. - Enforce memory ceilings independently of page-aligned allocations and prevent strict memory mode from falling back to disk. - Route unknown-size streams through HybridCache and support sequential writes without unnecessary file preallocation. - Bound downloader cache decisions by its concurrent working set and validate cache policy configuration. - Add policy, backing-store selection, stream override, cleanup, and downloader ceiling tests.
vxtls
marked this pull request as draft
September 12, 2026 02:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
Add a user-selectable
cache_policyconfiguration withauto,memory, anddiskmodes. The default remainsauto, and the policy can also be set throughOPENLIST_CACHE_POLICY.Improve
automode so known-size workloads are admitted to memory only when the complete workload ceiling passes the memory check; otherwise, the cache uses disk from the start. Unknown-size workloads use disk inautomode.Preserve HybridCache's existing memory-to-disk spill mechanism for workloads admitted by
auto, while makingmemoryanddiskstrict policies that do not silently switch backing stores.Add per-instance cache policy overrides for file streams and downloaders so callers can reuse HybridCache with workload-specific policy decisions without changing global configuration.
Route unknown-size streams through HybridCache's sequential writer and bound downloader admission by its maximum concurrent working set instead of the complete download size.
Enforce logical memory ceilings independently of page-aligned allocations and add coverage for policy parsing, backing-store selection, spill behavior, stream overrides, cleanup, and downloader ceilings.
This PR has breaking changes.
/ 此 PR 包含破坏性变更。
This PR changes public API, config, storage format, or migration behavior.
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
This PR requires corresponding changes in related repositories.
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Related Issues / 关联 Issue
Closes #3073
Testing / 测试
go test ./...TestNewOSSClientUsesEnvironmentHTTPSProxytest expected*http.Transportand received*net.safeTransport.go test ./internal/cache ./internal/conf ./internal/hybrid_cache ./internal/streamgo test ./internal/net -run '^TestDownloaderMemoryCeiling$'go vet ./internal/cache ./internal/conf ./internal/hybrid_cache ./internal/net ./internal/streamgo build ./...Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。