Skip to content

fix(s3): encode multipart fixture paths #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ILoveScratch2 merged 1 commit into from
Sep 14, 2026
Merged

fix(s3): encode multipart fixture paths #3074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion server/s3/multipart_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package s3
import (
"bytes"
"context"
"encoding/json"
"errors"
"os"
"path/filepath"
Expand Down Expand Up @@ -67,11 +68,21 @@ func setupMultipartBackend(t *testing.T) (*s3Backend, string) {
t.Fatalf("mkdir local root: %v", err)
}
t.Cleanup(func() { _ = os.RemoveAll(localRoot) })
addition, err := json.Marshal(struct {
RootFolderPath string `json:"root_folder_path"`
Thumbnail bool `json:"thumbnail"`
}{
RootFolderPath: localRoot,
Thumbnail: false,
})
if err != nil {
t.Fatalf("marshal local storage addition: %v", err)
}

_, err = op.CreateStorage(ctx, model.Storage{
Driver: "Local",
MountPath: mount,
Addition: `{"root_folder_path":"` + localRoot + `","thumbnail":false}`,
Addition: string(addition),
})
if err != nil {
t.Fatalf("create local storage: %+v", err)
Expand Down