Conversation
- Pin gofakes3 with conditional PUT, multipart completion, and copy support - Derive object ETags from content and preserve matching multipart validators - Keep conditional requests in the S3 handler instead of redirecting them - Format modification times in UTC and propagate storage errors - Close content readers and discard metadata after successful deletion - Add regression tests for object hashes, metadata, and conditional redirects Co-authored-by: Codex <267193182+codex@users.noreply.github.com> Signed-off-by: jyxjjj <16695261+jyxjjj@users.noreply.github.com>
jyxjjj
marked this pull request as draft
September 10, 2026 15:39
Member
Author
|
需要等待依赖合并后更新提交哈希 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
驱动没有提供 MD5 时,需要完整读取对象计算 ETag,包括 HEAD 和 Range 请求,会增加读取开销。Multipart ETag 保存在内存元数据中,重启后改用内容 MD5。
并发保护限于同一个 GoFakeS3 实例中的相同 bucket/key,不涵盖外部写入或多个实例。
Related repository PRs / 关联仓库 PR:
Related Issues / 关联 Issue
Fixes #3067
Testing / 测试
go test ./...OpenList 集成测试和完整测试套件因所需依赖不可用而未完成。
已添加 OpenList 对象哈希、multipart 元数据和条件重定向回归测试,但尚未执行成功。
Checklist / 检查清单
gofmt,go fmt, orprettierwhere applicable.AI Disclosure / AI 使用声明
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Tests / 测试
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution.I can reproduce all AI-assisted content included in this PR without any AI tools.