Skip to content

feat(i18n): add storage details cooldown and timeout setting labels - #641

Open
Vurliy wants to merge 1 commit into
OpenListTeam:mainfrom
Vurliy:fix/storage-details-async-and-cooldown
Open

Vurliy wants to merge 1 commit into
OpenListTeam:mainfrom
Vurliy:fix/storage-details-async-and-cooldown

Conversation

@Vurliy

@Vurliy Vurliy commented Aug 19, 2026 •

Copy link
Copy Markdown

Summary / 摘要

English

Adds English labels to src/lang/en/settings.json for the two storage details settings introduced by the backend PR OpenListTeam/OpenList#2950. Without them, the admin settings page shows the raw keys.

Key Label Backend default
storage_details_timeout_seconds Storage details background timeout (seconds) 15 (range 1–600)
storage_details_cooldown_seconds Storage details refresh cooldown (seconds) 0, off (range 0–86400)
  • Timeout: how long a background capacity probe may run before it is abandoned.
  • Cooldown: after a successful probe, refreshes within this period are served from the cache, to avoid hitting drive API rate limits.

The keys are inserted in alphabetical order, between sso_postmessage_origin and text_types. Other languages are expected to come through Crowdin.

Merge order: this PR can be merged before the backend. The extra keys are unused until then and have no side effect. If the backend is released first, its build bundles a frontend release without these labels, and the two settings show their raw keys until the next frontend release.

中文

为后端 PR OpenListTeam/OpenList#2950 新增的两个存储容量设置项,在 src/lang/en/settings.json 中添加英文文案。缺少这两条文案时,管理后台设置页会直接显示原始键名。

键 文案 后端默认值
storage_details_timeout_seconds Storage details background timeout (seconds) 15(范围 1–600)
storage_details_cooldown_seconds Storage details refresh cooldown (seconds) 0,关闭(范围 0–86400)
  • 超时:后台容量探测的最长运行时间,超时后放弃本次探测。
  • 冷却:上次成功探测后的这段时间内,刷新直接返回缓存,避免触发网盘 API 限流。

两个键按字母顺序插入在 sso_postmessage_origin 和 text_types 之间。其他语言预计通过 Crowdin 同步。

合并顺序:此 PR 可以先于后端合并,在后端合并前多出的键不会被引用,没有副作用。如果后端先发布,后端构建时打包的前端版本中没有这两条文案,设置页会显示原始键名,直到下一个前端版本发布。

  • This PR has breaking changes.
    / 此 PR 包含破坏性变更。
  • This PR changes public API, config, storage format, or migration behavior.
    / 此 PR 修改了公开 API、配置、存储格式或迁移行为。
  • This PR requires corresponding changes in related repositories.
    / 此 PR 需要关联仓库同步修改。

Related repository PRs / 关联仓库 PR:

Related Issues / 关联 Issue

Relates to OpenListTeam/OpenList#1815, OpenListTeam/OpenList#2633, OpenListTeam/OpenList#2635

Testing / 测试

  • go test ./...
  • Manual test / 手动测试:

English

  • Verified in a local development build that includes the backend changes: the admin settings page shows both labels.
  • prettier --check (3.9.6, the project's version) passes for src/lang/en/settings.json, and the keys are in alphabetical order.
  • go test ./... does not apply to this repository.

中文

  • 已在包含后端改动的本地开发版本中验证:管理后台设置页能正确显示这两条文案。
  • src/lang/en/settings.json 通过了 prettier --check(3.9.6,与项目版本一致),键按字母顺序排列。
  • go test ./... 不适用于本仓库。

Checklist / 检查清单

  • I have read CONTRIBUTING.
    / 我已阅读 CONTRIBUTING。
  • I confirm this contribution follows the repository license, contribution policy, and code of conduct.
    / 我确认此贡献符合仓库许可证、贡献规范和行为准则。
  • I have formatted the changed code with gofmt, go fmt, or prettier where applicable.
    / 我已按适用情况使用 gofmt、go fmt 或 prettier 格式化变更代码。
  • I have requested review from relevant maintainers or code owners where applicable.
    / 我已在适用情况下请求相关维护者或代码所有者审查。

AI Disclosure / AI 使用声明

  • This PR includes AI-assisted content.
    / 此 PR 包含 AI 辅助内容。

Tools used / 使用工具:

  • ChatGPT
  • Codex
  • GitHub Copilot
  • Claude
  • Gemini
  • Other (please specify) / 其他(请注明):

Usage scope / 使用范围:

  • Code generation / 代码生成

  • Refactoring / 重构

  • Documentation / 文档

  • Tests / 测试

  • Translation / 翻译

  • Review assistance / 审查辅助

  • I have reviewed and validated all AI-assisted content included in this PR.
    / 我已审核并验证此 PR 中的所有 AI 辅助内容。

  • I have ensured that all AI-assisted commits include Co-Authored-By attribution.
    / 我已确保所有 AI 辅助提交都包含 Co-Authored-By 归属信息。

  • I can reproduce all AI-assisted content included in this PR without any AI tools.
    / 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。

Note: The commit was authored by Codex (attributed via the commit author; it has no Co-authored-by trailer). The original description was written with Gemini, and this updated description and the review were done with Claude.

说明:本 PR 的提交由 Codex 生成(通过提交作者字段标注,没有 Co-authored-by)。最初的描述由 Gemini 辅助撰写;本次更新的描述和审查由 Claude 辅助完成。

@pikachuren pikachuren left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

结论:可以合并,有一处排版建议

只新增两个 i18n key,配合后端的存储详情冷却与超时配置项,改动干净、无副作用。文案表述清晰,把「刷新冷却」和「后台超时」区分得很明确,加了 (seconds) 单位提示也有助于管理员理解填什么值。

一个小建议:src/lang/en/settings.json 现有的 148 个 key 是严格按字母序排列的(我核对过,末尾依次是 upload_task_threads_num、version、video_autoplay、video_types、webauthn_login_enabled)。这次两个新 key 追加在了 webauthn_login_enabled 之后,破坏了这个顺序。按字母序它们应该插到 sso_... 与 token 之间的位置。

这不影响功能,但保持有序在这类文件上有实际价值:新增 key 时容易定位、减少多人同时改动时的冲突,Crowdin 侧的 diff 也更干净。建议调整一下位置。

另外提醒一点节奏问题:这些 key 对应的后端配置项如果尚未合并,前端先合入不会有副作用(多余的 key 只是不被引用),但反过来后端先上线则会显示原始 key 名。建议与后端 PR 协调好先后顺序。

@pikachuren pikachuren left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

增量评审:排序建议已响应 ✅

核对上次评审的两点建议:

一、settings.json key 字母序已调整 ✅
storage_details_cooldown_seconds 和 storage_details_timeout_seconds 已从 webauthn_login_enabled 之后移动到 sso_organization_name 与 text_types 之间,符合文件既有的字母序规范。

二、与后端合并顺序提醒(维持)
仍需与后端配置项 PR 协调先后顺序:后端先上线时这些配置项会显示原始字段名。建议确认后端状态后安排合并。

改动仅排序调整、无功能影响,可合并。

@Vurliy
Vurliy force-pushed the fix/storage-details-async-and-cooldown branch from ecc33f2 to 257f6d7 Compare October 29, 2026 09:02
@Vurliy

Vurliy commented Oct 31, 2026

Copy link
Copy Markdown
Author

@pikachuren 感谢两次审查!关于合并顺序:后端 OpenListTeam/OpenList#2950 已重写为精简版,这两个配置项的名称没有变化。后端构建时会打包前端最新发布的版本,所以前端可以先合并:在后端合并前,多出的键不会被引用,没有副作用;后端合并后,设置页就能直接显示正确的文案。PR 描述也已同步更新。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants