Run Nosetests via GitHub Actions#332
Open
peternewman wants to merge 25 commits into
Open
Conversation
Resync with upstream
Please check this manually before merging
Enable nosetests
Add conditional installation of 'nose' for nosetests task
Add additional links to HTTP error handling test
Please check this manually before merging
Added installation of lintian for spellintian task and run apt-get update first in case our cache is stale
kripton
approved these changes
Jul 8, 2026
| globals = {} | ||
| locals = {} | ||
| execfile("data/controller_data.py", globals, locals) | ||
| # Python 2 and 3 compatible version of execfile |
Member
There was a problem hiding this comment.
Do we need Python2-compatibility in 2026 any more?
| (0x00B9, "http://en.gzsjlight.com/"), | ||
| (0x00A9, "http://www.richter-lt.de/"), | ||
| (0x00B0, "https://arenaluci.it/en/"), | ||
| # (0x00B9, "http://en.gzsjlight.com/"), # Website currently gone |
Member
There was a problem hiding this comment.
Do we have an automatic test for that? Or do you manually check them from time to time?
Member
There was a problem hiding this comment.
Oh ok, I see the Python script for that down below. Solved.
| @@ -134,17 +134,17 @@ | |||
| (0x4C73, "http://www.lsclighting.com/"), | |||
| (0x4D41, "http://www.malighting.com/"), | |||
Member
There was a problem hiding this comment.
Probably should be https as well? Or is it up to them to update their address to some DB that we just fetch from?
| self.fail("Link %s failed due to socket error %s" % (link, e.errno)) | ||
| else: | ||
| self.assertEqual(response.code, 200, | ||
| self.assertTrue(((response.code == 200) or (response.code == 202)), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.