Fix compilation by removing template id from constructor#1989
Open
aroffringa wants to merge 2 commits intoOpenLightingProject:masterfrom
Open
Fix compilation by removing template id from constructor#1989aroffringa wants to merge 2 commits intoOpenLightingProject:masterfrom
aroffringa wants to merge 2 commits intoOpenLightingProject:masterfrom
Conversation
DaAwesomeP
approved these changes
Mar 21, 2026
aroffringa
force-pushed
the
fix-template-id-in-constructor
branch
from
4006f21 to
6f8c97c
Compare
Contributor
Author
|
I've rebased the branch, but it could be this is now redundant: #2012 also did some changes to the same line, but with a different solution. I hadn't seen that fix and somehow didn't have it in my local clone yet. It is though more >= C++11 ish to delete the constructor as in my fix, compared to the use of macros, but if we want to move in that direction it might be better to remove the macro and all uses of it at once. I'm happy to make that change -- Is that a direction we should move, @nomis52 , or would you rather close this MR for now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1982.
(The use of macro's like this might be reconsidered as well, it's not very C++-ish.)