Fixed misleading expansion variable log message in ci.common - #532
Open
sajeerzeji wants to merge 2 commits into
Open
Fixed misleading expansion variable log message in ci.common#532sajeerzeji wants to merge 2 commits into
sajeerzeji wants to merge 2 commits into
Conversation
venmanyarun
approved these changes
Aug 17, 2026
cherylking
requested changes
Aug 19, 2026
|
|
||
| // Log after appendTail so sb holds the complete resolved value | ||
| for (String varName : matchedVarNames) { | ||
| log.info(String.format("Resolved environment variable \"%s\" in path \"%s\" to \"%s\"", varName, value, sb)); |
Member
There was a problem hiding this comment.
since this is done at the very end after the while loop...I don't get how it is showing the actual value for the particular variable....every variable that got resolved in the while loop will report the same sb as the value.
Now I understand that in that while loop, this same method got called recursively...so it will also print this log message for those variables. I just don't get the value in repeating the same value and sb for each variable in matchedVarNames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OpenLiberty/ci.maven#2076
Reference: OpenLiberty/ci.maven#2076 (comment)
Moved the log call to after the full string is assembled, so the complete resolved path is shown, and updates the message format to clearly state which variable was expanded, the original expression it appeared in, and the fully resolved result. The corresponding IT assertions in ci.maven and ci.gradle are updated to match the new message format.