fix: use BareBonesBrowserLaunch for Privacy Policy link on all platforms#264
Open
dowel015 wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
Open
fix: use BareBonesBrowserLaunch for Privacy Policy link on all platforms#264dowel015 wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
dowel015 wants to merge 1 commit intoOpenIntegrationEngine:mainfrom
Conversation
Desktop.getDesktop().browse() throws on some Linux platforms even when Desktop.isDesktopSupported() returns true, causing the Privacy Policy hyperlink in FirstLoginDialog to silently fail. Replace the Desktop if/else with a direct call to BareBonesBrowserLaunch.openURL() which works reliably cross-platform. Fixes OpenIntegrationEngine#86. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
@dowel015, this one also looks good, but needs a DCO. Please add. |
Contributor
|
Be carefull, commit come from claude AI, a licencing problem can appear |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop.isDesktopSupported()returnstruebutDesktop.getDesktop().browse()throws an exception, causing the Privacy Policy hyperlink in the first login dialog to silently failDesktopAPI usage entirely from the hyperlink listenerBareBonesBrowserLaunch.openURL()directly, which works reliably cross-platformFixes #86
Test plan
🤖 Generated with Claude Code