[#111] Give embedded OpenDJ 30 s to start and stop in LDAP connector tests#113
Merged
vharseko merged 1 commit intoJul 21, 2026
Conversation
…penIdentityPlatform#111) waitUntilStopped() allowed only 25 x 200 ms = 5 s for the server to shut down; on a loaded CI runner the stop after applying test-config.ldif can exceed that, failing before() and cascade-skipping the module's tests. Raise the budget to 30 s, and align waitUntilListening() (10 s -> 30 s), which fails the same way. Both loops exit as soon as the server is actually up/down, so the successful case is unaffected.
vharseko
added
ci
vharseko
changed the title
maximthomas
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111.
Problem
LdapConnectorTestBase.waitUntilStopped()gives the embedded OpenDJ only 25 × 200 ms = 5 s to shut down. On a loaded CI runner the stop after applyingtest-config.ldifcan exceed that, sostartAndApplythrows frombefore(). A failure in a configuration method is not forgiven by surefire reruns (Run 1: FAIL, Run 2–3: PASS in the observed run), so the module fails and cascade-skips the remaining tests (309 skipped in https://github.com/OpenIdentityPlatform/OpenICF/actions/runs/29743183432/job/88354582201).Change
waitUntilStopped(): shutdown budget 5 s → 30 s (ITERATIONS25 → 150). Covers both call sites —startAndApply()andstopServer().waitUntilListening(): startup budget 10 s → 30 s (ITERATIONS50 → 150) — same failure class on a slow runner, aligned while at it.Both loops exit as soon as the server is actually up/down, so the successful case is unaffected; the change only widens the margin on slow runners.
Testing
mvn test -Dtest=LdapDeleteTests(the class that failed in CI) against the embedded OpenDJ: 3 tests, 0 failures, 0 errors.