Skip to content

majestic: make S95majestic stop work when the pidfile is stale #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phedoreanu wants to merge 2 commits into
base: master
Choose a base branch
from
+18 −5
Open

majestic: make S95majestic stop work when the pidfile is stale #2245

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8e3df3
majestic: make S95majestic stop work when the pidfile is stale
phedoreanu Aug 9, 2026
0945701
S95majestic: report stop failure instead of claiming success
phedoreanu Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions general/package/majestic/files/S95majestic
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,28 @@ start() {
fi
}

# Stop by pidfile, then verify the daemon is actually gone. majestic's own
# watchdog restarts it with a new pid that start-stop-daemon knows nothing
# about, so the pidfile goes stale; -K on a stale pidfile kills nothing, and
# "restart" then starts a SECOND majestic next to the running one - both
# fighting over the encoder, with config edits silently never loaded. killall
# matches by name, which is the one identity that cannot go stale.
stop() {
echo -n "Stopping $DAEMON: "
start-stop-daemon -K -q -p "$PIDFILE"
if [ $? -eq 0 ]; then
rm -f "$PIDFILE"
echo "OK"
else
sleep 1
if pidof "$DAEMON" > /dev/null 2>&1; then
killall "$DAEMON" 2> /dev/null
sleep 2
killall -9 "$DAEMON" 2> /dev/null
sleep 1
fi
if pidof "$DAEMON" > /dev/null 2>&1; then
echo "FAIL"
return 1
fi
rm -f "$PIDFILE"
echo "OK"
Comment thread
qodo-free-for-open-source-projects[bot] marked this conversation as resolved.
}

case "$1" in
Expand All @@ -31,7 +44,7 @@ case "$1" in
;;

restart)
stop
stop || exit 1
sleep 3
start
;;
Expand Down