Enable continuous ACK by default for all handshakes#26
Merged
Conversation
The fast-boot bootrom window (<100ms) affects manual power cycling too, not just automated. Enable continuous 0xAA sending by default — it's harmless to running systems and catches the bootrom reliably in all cases (TUI, CLI, automated). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TUI recovery fails on hi3516ev300 — handshake succeeds but DDR step fails. The fast-boot bootrom window (<100ms) affects manual power cycling too, not just automated. PR #25 only enabled continuous ACK when a power controller was configured.
Fix
Default
_continuous_ack = TrueinHiSiliconStandard.__init__. Sending0xAAevery 50ms while waiting is harmless to running systems and catches the bootrom reliably in all cases (TUI, CLI, automated).Verified
--power-cycle): DDR → SPL → U-Boot → complete🤖 Generated with Claude Code