[codex] Improve UART port discovery labels#23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/dev/uart-*defib portshuman and JSON output to expose the same richer port identity while keeping existing JSON keysdefibaccepts either raw/dev/ttyUSB*paths or stable aliases like/dev/uart-orangepi5plusWhy
When multiple identical USB UART adapters are connected, the old UI only showed
/dev/ttyUSB* - FT232R USB UART, which makes adapter selection ambiguous. This change keeps the existing--portcontract but makes multi-adapter setups distinguishable and friendlier.User impact
Users with simple setups can keep using
/dev/ttyUSB0exactly as before. Users with multiple adapters get much clearer labels, and Linux users who create stable/dev/uart-*symlinks will see and use those aliases automatically.Validation
uv run pytest tests/test_serial_ports.py tests/test_cli.py tests/test_tui.py