fix(llm): add provider-specific verified model lists for gemini, deepseek, moonshot, minimax#2386
Merged
juanmichelini merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
…seek, moonshot, minimax Models in VERIFIED_OPENHANDS_MODELS were missing from their provider-specific lists (gemini, deepseek, moonshot, minimax), causing them to appear in the OpenHands verified models UI but not under their actual provider. Changes: - Add VERIFIED_GEMINI_MODELS with gemini-3-pro-preview - Add VERIFIED_DEEPSEEK_MODELS with deepseek-chat - Add VERIFIED_MOONSHOT_MODELS with kimi-k2-thinking, kimi-k2.5 - Add VERIFIED_MINIMAX_MODELS with minimax-m2.5 - Register new lists in VERIFIED_MODELS dict - Add test that every model in VERIFIED_OPENHANDS_MODELS also appears in a provider-specific list - Update ADDINGMODEL.md to document the requirement Fixes #2385 Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
API breakage checks (Griffe)Result: Passed |
Contributor
Agent server REST API breakage checks (OpenAPI)Result: Failed Log excerpt (first 1000 characters) |
Contributor
all-hands-bot
approved these changes
Mar 11, 2026
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean fix following existing patterns exactly. Regression test prevents this from happening again. lgtm! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2385
Models in
VERIFIED_OPENHANDS_MODELSwere appearing in the OpenHands verified models UI but not under their actual provider, because no provider-specific list existed forgemini,deepseek,moonshot(Kimi), andminimax.Diagnosis
The following models were in
VERIFIED_OPENHANDS_MODELSbut had no corresponding provider list:gemini-3-pro-preview→ nogeminilistdeepseek-chat→ nodeepseeklistkimi-k2-thinking,kimi-k2.5→ nomoonshotlistminimax-m2.5→ nominimaxlist(The original reporter's example
claude-sonnet-4-6was already fixed in #2104.)Changes
openhands-sdk/openhands/sdk/llm/utils/verified_models.pyVERIFIED_GEMINI_MODELS = ["gemini-3-pro-preview"]VERIFIED_DEEPSEEK_MODELS = ["deepseek-chat"]VERIFIED_MOONSHOT_MODELS = ["kimi-k2-thinking", "kimi-k2.5"]VERIFIED_MINIMAX_MODELS = ["minimax-m2.5"]VERIFIED_MODELSdicttests/sdk/llm/test_model_list.pytest_openhands_models_all_have_provider_list— ensures every model inVERIFIED_OPENHANDS_MODELSalso appears in at least one provider-specific list, preventing this class of regression..github/run-eval/ADDINGMODEL.mdVERIFIED_OPENHANDS_MODELS, it must also be added to its provider-specific list (creating a new one if needed).Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:6294ebb-pythonRun
All tags pushed for this build
About Multi-Architecture Support
6294ebb-python) is a multi-arch manifest supporting both amd64 and arm646294ebb-python-amd64) are also available if needed