Skip to content

Bump Tesla to 1.18.2 to fix mid-stream transport error crashes#4782

Open
elias-ba wants to merge 1 commit into
mainfrom
4781-bump-tesla
Open

Bump Tesla to 1.18.2 to fix mid-stream transport error crashes#4782
elias-ba wants to merge 1 commit into
mainfrom
4781-bump-tesla

Conversation

@elias-ba
Copy link
Copy Markdown
Contributor

@elias-ba elias-ba commented May 20, 2026

Description

Upgrades Tesla from 1.15.3 to 1.18.2. The Finch adapter in 1.15.3 raises CaseClauseError on the 3-tuple error shape Finch returns when a streaming connection drops mid-response, which crashes the AI assistant worker. Tesla 1.16.0 (elixir-tesla/tesla#819) handles the shape gracefully so the worker can return a normal error; 1.18.2 is the latest stable on that line.

Closes #4781.

Validation steps

  1. mix compile --warnings-as-errors succeeds.
  2. Tesla-using suites pass: apollo_client, adaptor_registry, auth_providers, github_client, usage_tracking, ai_assistant, version_control.

Additional notes for the reviewer

AI Usage

  • I have used Claude Code

Pre-submission checklist

  • I have performed an AI review of my code
  • I have implemented and tested all related authorization policies
  • I have updated the changelog
  • I have ticked a box in "AI usage" in this PR

@github-actions
Copy link
Copy Markdown

Security Review ✅

  • S0 (project scoping): N/A — PR only bumps Tesla to 1.18.2 (CHANGELOG, mix.exs, mix.lock); no application code, queries, or web-layer entrypoints changed.
  • S1 (authorization): N/A — no new controller actions, LiveView handlers, or policy modules touched.
  • S2 (audit trail): N/A — no writes to project/instance configuration resources introduced.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.2%. Comparing base (79a9ecc) to head (46547e7).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4782     +/-   ##
=======================================
- Coverage   90.2%   90.2%   -0.0%     
=======================================
  Files        442     442             
  Lines      22439   22439             
=======================================
- Hits       20242   20236      -6     
- Misses      2197    2203      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elias-ba
Copy link
Copy Markdown
Contributor Author

@josephjclark @stuartc this little PR here solves a real bug in the AI Assistant where the streaming events/errors make it crash. I would love it to be merged asap please

@elias-ba elias-ba requested review from stuartc and removed request for midigofrank May 24, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New Issues

Development

Successfully merging this pull request may close these issues.

Upgrade Tesla to 1.18.x to handle Finch streaming transport errors

1 participant