Epic: Single Sign On#4751
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4751 +/- ##
=======================================
- Coverage 90.3% 90.2% -0.1%
=======================================
Files 442 447 +5
Lines 22540 22735 +195
=======================================
+ Hits 20353 20507 +154
- Misses 2187 2228 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Now I have enough information to perform the security review. This PR adds SSO functionality (GitHub/Google OAuth providers, identity linking/unlinking, signup confirmation). Let me assess each check: S0 (project scoping): The PR touches only user accounts, identities, sessions, and OAuth flows — none of which are project-scoped resources (no work with workflows, runs, dataclips, work orders, collections, project credentials, triggers, edges, or jobs). New queries ( S1 (authorization): New web entrypoints check authorization appropriately:
S2 (audit trail): Per the agent guidance, S2 applies to project/instance configuration changes. This PR modifies user-level account state (registration, identity linking) — analogous to existing account operations (signup, password change) which do not write to Security Review ✅
|
Description
This PR Implements the Full SSO Experience epic.
AccountHookas password sign-ups. ***Closes #4621
Validation steps
Setup
<host>/authenticate/<provider>/callbackwhere isgoogleorgithubfor now.GITHUB_CLIENT_IDandGITHUB_CLIENT_SECRET.Validation
Sign up via SSO
Sign in via SSO
Email collision
you@domain.com+ SSO sign-up with same emailuser_identitiesrow createdLink from
/profileUnlink from
/profileForgot password (SSO-only)
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)