Step events aren't appearing realtime on canvas #4326
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4326 +/- ##
==========================================
+ Coverage 89.29% 89.36% +0.06%
==========================================
Files 425 425
Lines 19994 19994
==========================================
+ Hits 17854 17867 +13
+ Misses 2140 2127 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replaces manual field mapping with a reusable toStep() helper to reduce code duplication and improve type safety when converting step-like objects (StepDetail, RunDetail.steps) to the Step type used in the cache. Also adds missing TypeScript interface definitions for test helper methods introduced in the race condition fix.
lmac-1
left a comment
lmac-1
left a comment
There was a problem hiding this comment.
Haven't looked too much at the code yet but I'm not seeing this working as expected:
https://www.loom.com/share/88e0eab1345e4f60a457577fbca49e0d
- Success formatting at the end sometimes not coming through
- Result of each step doesn't seem to be streaming in
|
Aaah, good catch @lmac-1 |
- Add useFollowRun call in diagram to subscribe to run channel - Remove cache invalidation on history_updated events - Parse initial run data during store creation to fix race condition - Update documentation to clarify history vs run step channel separation This allows step highlights to update incrementally as steps execute, rather than invalidating the entire cache on run updates.
…t-step-results-realtime
- Add fallback cache invalidation when runs reach final state - Fix input_dataclip_id type to allow null values - Remove unnecessary non-null assertion in toStep mapper - Ensure components get refreshed data when runs complete
Add _viewRun method to history store mock to fix test failures caused by missing method called in useHistory hook.
|
Hey @lmac-1, I have fixed the issue and requested for another review |
|
Thanks @midigofrank. Sorry I didn't quite manage a full review today. I have clicked through and given it a test locally and can confirm it's working now. I won't be able to look into the code properly until tomorrow after my 1-1 with Roina. Feel free to reassign the review if this is too late. Thanks! |
|
@midigofrank reviewing now 😊 |
|
Sorry for the to-ing and fro-ing on this one. I need to organise some things before my flight so won't be able to review this properly. I thought I had time but time is quite tight to pack and sort stuff. @doc-han are you able to review? |
Description
This PR ensures that steps in a workflow are highlighted in realtime as the steps are updated
Closes #4261
Validation steps
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)