1254 remove run fks#1522
Closed
rorymckinley wants to merge 8 commits intomainfrom
Closed
Conversation
Member
|
@rorymckinley , @stuartc , can i close this? |
Contributor
|
Closing due to inactivity @rorymckinley - please reopen if this is in error |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1522 +/- ##
=======================================
Coverage 87.71% 87.71%
=======================================
Files 218 218
Lines 6593 6596 +3
=======================================
+ Hits 5783 5786 +3
Misses 810 810 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for the reviewer
This is a WIP and requires #1453 to be merged in before this PR can be completed. If #1453 is merged in, the shim migration can be reverted.
At the moment, I think all failing tests are due to #1453 not being merged in.
Related issue
Fixes #
Review checklist