Skip to content

1254 remove run fks#1522

Closed
rorymckinley wants to merge 8 commits intomainfrom
1254-remove-run-fks
Closed

1254 remove run fks#1522
rorymckinley wants to merge 8 commits intomainfrom
1254-remove-run-fks

Conversation

@rorymckinley
Copy link
Copy Markdown
Collaborator

Notes for the reviewer

This is a WIP and requires #1453 to be merged in before this PR can be completed. If #1453 is merged in, the shim migration can be reverted.

At the moment, I think all failing tests are due to #1453 not being merged in.

Related issue

Fixes #

Review checklist

  • I have performed a self-review of my code
  • I have verified that all appropriate authorization policies have been implemented and tested
  • If needed, I have updated the changelog
  • Product has QA'd this feature

@taylordowns2000
Copy link
Copy Markdown
Member

@rorymckinley , @stuartc , can i close this?

@github-project-automation github-project-automation Bot moved this from Icebox to Done in Core Apr 9, 2026
@brandonjackson
Copy link
Copy Markdown
Contributor

Closing due to inactivity @rorymckinley - please reopen if this is in error

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.71%. Comparing base (70a2023) to head (0979a95).
⚠️ Report is 1495 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1522   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files         218      218           
  Lines        6593     6596    +3     
=======================================
+ Hits         5783     5786    +3     
  Misses        810      810           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants