Update version hash #1238
Open
Update version hash #1238
+662
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't include keys in the hash - Fixes for edges and triggers
This aligns the implementation a lot closer to lightnign A couple of fixes in support of this
josephjclark
commented
Jan 26, 2026
Collaborator
Author
|
Ok, that was super hard to debug, but I've finally got CLI and Lightning hashes to look identical. All tests should be passing on this branch, so I've gotta investigate those fails before I can merge down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rewrite of the version hash algorithm to better align with Lightning
I am now convinced that lightning and the CLI MUST generate identical hashes, otherwise we can't really work out what's changed when deploying.
The basic strategy here is, rather than use the Project structure to generate the hash, convert to app state and use that. This means we're much more closer to the lightning structure, and it's a lot easier to compare the algos.
Fixes #1078
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy