Stop publishing feign-bom twice during release - #3568
Merged
Conversation
Signed-off-by: Marvin Froeder <velo.br@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
Publish BOM to Maven Centralstep from the release job.feign-bomis already published by the regular reactordeploy, so this step uploaded a second, competing copy of the same coordinates on every release.What went wrong in 13.15
The step's bundle upload was rejected by Central:
The CircleCI job still went green, because the step only checks that the upload returns
201. Central validates asynchronously, so the failure surfaced later in the publisher portal and left a FAILED deployment sitting there to be dropped by hand.Why the step is obsolete
It was added in a551824 (Feb 2026), back when the reactor deploy did not produce a usable BOM. That changed in 44f688e (#3508, Aug 2026), which put
flatten-maven-pluginwithflattenMode=bomonfeign-bom. Since 13.14 the reactor deploy has been publishing the BOM on its own, and this step has been a duplicate.The published
feign-bom-13.15.pomconfirms which one won — it has no<parent>,<build>or<properties>, i.e. it is the flattened artifact from the reactor deploy.Why it is worth deleting rather than guarding
The step uploads
target/classes/feign-bom/pom.xml, the raw sundr-generated POM, which still carries<parent>,<build>and<properties>. That is precisely the unflattened shape #3508 removed because it overrides consumer dependency management. Today the duplicate loses the race and is rejected; if it ever won, it would republish the bug.Verification
circleci config validatepasses.nexus-deploynow has a single step,Deploy Core Modules Sonatype.feign-bomis not in the deploy's-plexclusion list, so the reactor continues to publish it.feign-vertx4-testandfeign-vertx5-test, are excluded from the deploy on purpose and are also missing at 13.14 — a pre-existing wart, untouched here.CI-only change; no Maven or Java sources affected.