MODULE: oauth2#2755
Conversation
hosuaby
force-pushed
the
feature/oauth2
branch
from
2c464af to
f6e283f
Compare
|
Ah, build fails cause I am using Testcontainers. What do you suggest? Do I disable all Tests using Testcontainers or there is a way to get a build environment with Docker on CircleCI? |
|
Well, I would say to either test using something else. Or figure how to get circle Ci working with test containers or need to move to GitHub actions |
I am doing experiments with pipeline. Please ignore notifications. When I will come up with a solution, I will inform you and make a separate PR. |
hosuaby
force-pushed
the
feature/oauth2
branch
from
46aa38f to
cde19b7
Compare
velo
left a comment
velo
left a comment
There was a problem hiding this comment.
Amazing work, tons of tests, nice improvements, no breaking change, sounds like a win win
| *** Dropwizard Metrics 5 | ||
| *** Micrometer | ||
| ** extras | ||
| *** OAuth2 |
| <version>${project.version}</version> | ||
| </dependency> | ||
|
|
||
| <dependency> |
There was a problem hiding this comment.
Ok, removed this addition. Anyway it will be added in my PR about Vertx.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Some suggestions could not be made:
- annotation-error-decoder/pom.xml
- lines 49-48
- apt-test-generator/pom.xml
- lines 62-61
- benchmark/pom.xml
- lines 70-69
- core/pom.xml
- lines 37-36
- googlehttpclient/pom.xml
- lines 54-53
- hc5/pom.xml
- lines 67-66
- httpclient/pom.xml
- lines 75-74
- hystrix/pom.xml
- lines 78-77
- jackson-jaxb/pom.xml
- lines 82-83
- java11/pom.xml
- lines 50-49
- jaxb-jakarta/pom.xml
- lines 55-57
- jaxb/pom.xml
- lines 45-49
- jaxrs2/pom.xml
- lines 103-102
- jaxrs3/pom.xml
- lines 89-88
- jaxrs4/pom.xml
- lines 83-82
- kotlin/pom.xml
- lines 71-70
- okhttp/pom.xml
- lines 59-58
- pom.xml
- lines 614-615
- reactive/pom.xml
- lines 98-97
- ribbon/pom.xml
- lines 83-82
- soap-jakarta/pom.xml
- lines 63-62
- lines 79-81
- soap/pom.xml
- lines 55-60
- lines 70-71
hosuaby
force-pushed
the
feature/oauth2
branch
from
1d3542b to
09735f5
Compare
|
Circle should be disabled now. Please update the branch and we'll try again. |
hosuaby
force-pushed
the
feature/oauth2
branch
from
09735f5 to
bb08816
Compare
hosuaby
force-pushed
the
feature/oauth2
branch
from
bb08816 to
dee0fb8
Compare
velo
force-pushed
the
master
branch
2 times, most recently
from
034970d to
f1200b9
Compare
velo
left a comment
velo
left a comment
There was a problem hiding this comment.
Thanks for the update. I can’t approve this state yet because required CI validation is not in a mergeable/green state for this PR branch. Please rebase/update the branch and ensure required checks are green, then I can re-review.
3 participants
Integration of OAuth2/OpenID flows into feign.
Following the discution: #2680