Remove amrex_utils.cpp from AWAE-C.vcxproj#3258
Merged
andrew-platt merged 1 commit intoOpenFAST:devfrom Mar 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Visual Studio build configuration for the AWAE-C module by removing an incorrectly included C++ source file from the project definition.
Changes:
- Removed
amrex_utils.cppfrom theAWAE-CVisual Studio C++ project compilation items.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
13
to
15
| <ItemGroup> | ||
| <ClCompile Include="..\..\modules\awae\src\vtk.cpp" /> | ||
| <ClCompile Include="..\..\modules\awae\src\amrex_utils.cpp" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
PR title/description refer to AWAE-C.vfproj, but the actual change is in AWAE-C.vcxproj (and there doesn't appear to be an AWAE-C.vfproj in vs-build/modules). Consider updating the PR title/description to match the file being fixed to avoid confusion when tracking build issues.
deslaughter
changed the title
andrew-platt
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge.
Feature or improvement description
Fixes issue where the
AWAE-C.vcxprojwouldn't build in Visual Studio because theamrex_utils.cppfile was incorrectly included. This branch was tested with thedeployaction and all the projects built successfully.Impacted areas of the software
Visual Studio AWAE-C project