AeroAcoustics cleanup + added driver code #3149
Open
+1,094
−776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make arrays allocated to size 2 be fixed-size arrays instead of allocatable - fix comments - cleanup multiple IF statements that could be a single IF/ELSEIF/ELSE statement - removed a few unused parameters and states - AFInfo parameters now passed separately in Init routine and not used afterwards - removed continuous and constraint states to match call to AA_UpdateStates, which had already removed those variables - added check that AD_Bl_Prctge is between 0-100% - allow `startnode` to be 1 if there aren't 2 blade nodes (required some changes in calculating `elementspan` for first node - pre-calculate element span (stored as a parameter instead of calculated inside DO loop each step - pre-calculate indices for TICalcMethod = 2 discrete state filter - fix bug in TICalcMethod state initialization (AllRegCounter) - fix bug in TICalcMethod TIVx calculation (was computing standard deviation instead of turbulence intensity)
andrew-platt
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This pull request cleans up some of the AeroAcoustics code. It also includes
TICalcMeth=2calculates the TI for the inflow noise calculations,BldPrcntparameter in the input file is entered between 0 and 100%,These updates should make the code run a bit faster, though I haven't profiled it to check.
I have also included source code for a new AeroAcoustics driver, but I've not added it to any build scripts.
Related issue, if one exists
This includes the element-size fix at the tip node that is introduced in #3133. So, that should be merged first (and if not, we should add a division-by-two to this code).
Impacted areas of the software
AeroAcoustics module of AeroDyn
Test results, if applicable
This should give the same results as #3133 for the aeroacoustics regression test here.
When
TICalcMeth=2andTIMod /= 0, this code will give different results because the calculated value of TI will be different in the InflowNoise routine.