Open
Conversation
geoalgo
reviewed
Apr 2, 2026
Collaborator
geoalgo
left a comment
geoalgo
left a comment
There was a problem hiding this comment.
LGTM, just have small comments.
| assert dataset in ["alpaca-eval", "arena-hard"] | ||
| assert dataset in [ | ||
| "alpaca-eval", | ||
| "arena-hard", |
| def download_all(): | ||
| print(f"Downloading all dataset in {data_root}") | ||
| for dataset in ["alpaca-eval", "arena-hard", "m-arena-hard"]: | ||
| for dataset in ["alpaca-eval", "m-arena-hard"]: |
Collaborator
There was a problem hiding this comment.
why not putting all in the loop?
| @@ -0,0 +1,69 @@ | |||
| from pathlib import Path | |||
Collaborator
There was a problem hiding this comment.
I would rather have those in a branch but not in main as it is user specific.
Collaborator
There was a problem hiding this comment.
Maybe we could add "and github contributors"?
Comment on lines
+21
to
+25
| "arena-hard-v0.1": ArenaHardSpec( | ||
| public_name="arena-hard-v0.1", | ||
| canonical_name="arena-hard-v0.1", | ||
| hf_repo_id=ARENA_HARD_HF_REPO_ID, | ||
| hf_variant="arena-hard-v0.1", |
Collaborator
There was a problem hiding this comment.
I am confused, public_name, canonical_name and hf_variant are all indentical why do we need them?
Also I think removing "arena-hard" in favor of the full specified dataset makes sense to me (like arena-hard-v0.1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.