-
Notifications
You must be signed in to change notification settings - Fork 127
shows results of removing client/mob verbs on client #2484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…erb removal more correct
…lso fix listx.Remove(listx) by copying the argument list before reading
|
Also I noticed that when reading/clearing |
|
@wixoaGit Thanks for the feedback. Let me know if those changes are good for what you have in mind. |
This reverts commit 7c46266.
Co-authored-by: wixoa <wixoag@gmail.com>
|
@wixoaGit I think this may have caused an issue where now the verbs can be a little hard to click, like sometimes I click a verb and nothing happens. I didn't notice that when i was testing this while it included the sleep. Have you noticed anything like that since this was merged? |
|
I haven't run into that, no I have been mostly testing paradise and tg though, which have their own stat panel implementation |
Closes #2342.
The verb list classes didn't override
ContainsKey,ContainsValue, orRemoveValue, which led to verb removal not working as expected. I also added an explicit verb refresh step to appearance updates on the client side. to ensure that atom verb updates are kept up to date on the client.Also, while testing
listx.Remove(listx)I had an issue where the list was being modified while iterated over so now list.remove will copy lists passed as arguments before iterating over them.Testing code on top of testgame:
Results:
thing1-4remove the mob verbs,thing5-8remove the client verbs.