Repository navigation
chore(js): upgrade vitest and coverage-v8 to 5 - #86
Open
g4bri3lDev wants to merge 1 commit into
Open
g4bri3lDev wants to merge 1 commit into
g4bri3lDev wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #82 and #84, which Dependabot opened separately but which must land together:
vitestand@vitest/coverage-v8need matching major versions.Changes
vitestand@vitest/coverage-v8:^3.2.7→^5.0.3.vitest.config.ts: excludesrc/wasm-core/**andsrc/**/*.d.tsfrom coverage. With vitest 5, coverage tries to parse the generated wasm-bindgen declaration files and logs aRolldownError: Parse failed … Missing initializer in const declarationon ambient declarations likeexport const memory: WebAssembly.Memory;. They're generated output, not code under test.CI doesn't run coverage, so this wouldn't have shown up in the checks on #84.
Verification
bun run type-checkpasses.bun run test: 74 passed.bun run test:coverageruns with no parse errors (98.8% statements, 100% lines; same as before).bun run buildsucceeds.Once this is merged, Dependabot closes #82 and #84 automatically.