Repository navigation
fix(touch): hold the GT911 reset line low instead of leaving it floating - #172
Open
cryptomilk wants to merge 1 commit into
Open
cryptomilk wants to merge 1 commit into
cryptomilk wants to merge 1 commit into
Conversation
On the reTerminal E1003, GPIO48 (TOUCH_RES) is the GT911's active-low hardware reset line. Dropping touch_controllers from the device config left it completely untouched, so it floated at whatever level it was last driven. That level is HIGH, meaning the chip stays out of reset and powered, both awake and across deep sleep, since a bare digitalWrite() doesn't survive sleep without a GPIO hold. initTouchInput() now drives the reset pin low for a touch_ic_type == OD_TOUCH_IC_NONE entry instead of skipping it. The new touchPrepareForDeepSleep() latches the reset/enable pin(s) with gpio_hold_en()/gpio_deep_sleep_hold_en() before esp_deep_sleep_start() so the level survives sleep. This also closes the same gap for an actively used touchscreen. It is now held in reset for the sleep window too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the reTerminal E1003, GPIO48 (TOUCH_RES) is the GT911's active-low hardware reset line. Dropping touch_controllers from the device config left it completely untouched, so it floated at whatever level it was last driven. That level is HIGH, meaning the chip stays out of reset and powered, both awake and across deep sleep, since a bare digitalWrite() doesn't survive sleep without a GPIO hold.
initTouchInput() now drives the reset pin low for a touch_ic_type == OD_TOUCH_IC_NONE entry instead of skipping it. The new touchPrepareForDeepSleep() latches the reset/enable pin(s) with gpio_hold_en()/gpio_deep_sleep_hold_en() before esp_deep_sleep_start() so the level survives sleep. This also closes the same gap for an actively used touchscreen. It is now held in reset for the sleep window too.