embedded-services: Fix cortex-m dependencies#760
Open
kurtjd wants to merge 1 commit intoOpenDevicePartnership:v0.2.0from
Open
embedded-services: Fix cortex-m dependencies#760kurtjd wants to merge 1 commit intoOpenDevicePartnership:v0.2.0from
kurtjd wants to merge 1 commit intoOpenDevicePartnership:v0.2.0from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts embedded-services’ ARM-specific dependency wiring so using the crate on non-ARM (e.g., RISC-V) no_std targets doesn’t accidentally pull in Cortex-M runtime/linker-script baggage.
Changes:
- Remove
cortex-m-rtfrom theembedded-servicesdependency graph. - Gate the
cortex-mdependency tocfg(all(target_os = "none", target_arch = "arm"))to avoid non-ARMno_stdbuilds pulling it in. - Regenerate affected lockfiles (workspace + examples) to reflect the dependency changes.
Reviewed changes
Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/std/Cargo.lock | Drops cortex-m-rt entries pulled in via embedded-services. |
| examples/rt685s-evk/Cargo.lock | Removes cortex-m-rt from embedded-services dependency list in the lock. |
| examples/rt633/Cargo.lock | Removes cortex-m-rt from embedded-services dependency list in the lock. |
| examples/pico-de-gallo/Cargo.lock | Drops cortex-m-rt entries pulled in via embedded-services. |
| embedded-service/Cargo.toml | Removes cortex-m-rt and gates cortex-m to ARM no_std targets only. |
| Cargo.lock | Updates workspace lock to remove cortex-m-rt from embedded-services deps. |
27b004e to
49aa58f
Compare
williampMSFT
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the cortex-m-rt dependency entirely since this is not needed and risks pulling in conflicting linker scripts depending on where they are in relation to each other in the search graph when embedded-services is used on a different architecture. Then also made cortex-m only included if the architecture is arm to be extra-safe.
Fixes a minor issue I was running into trying to work on a risc-v platform.