Conversation
Co-authored-by: BunsDev <68980965+BunsDev@users.noreply.github.com>
Co-authored-by: BunsDev <68980965+BunsDev@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job platform-conformance (win32-x64)
Align conformance producer revision with protected validator lock
Sep 20, 2026
Member
|
Closing: producer resolution is already explicit. #314 added the producer_revision dispatch input with an ancestry gate, and protected runs are dispatched with the revision the SDK validator binds (for example run 35566636457 with producer ac1c4f4). The failures these branches chase were a MAX_PATH overflow in aws-lc-sys on Windows, diagnosed on #219 (issuecomment-5757703171) and fixed in #348. Defaulting the producer from the SDK lock would also change a governed workflow outside the repin process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platform-conformance (win32-x64)was failing inphase1.stage.evidence-authority.checkoutbecause the workflow defaulted producer selection to the dispatch tip, which can diverge from the protected validator lock’s expectedevidenceProducer.commit. This change makes producer resolution lock-driven by default and keeps protected revision checks explicit.Producer revision resolution (workflow hardening)
producer-revision, wheninputs.producer_revisionis omitted, resolve from:.phase1-counterparts/sdk-validator/conformance/client-v1-cross-repository-lock.jsonevidenceProducer.commitgithub.shaso only merged commits are accepted.Protected validator consistency gate
inputs.validator_revisionto exactly matchvars.CLIENT_V1_CONFORMANCE_VALIDATOR_REVISIONbefore deriving defaults.evidenceProducer.commitContract/test/docs synchronization
.github/workflows/client-v1-conformance.yml(size/SHA row) to match committed bytes.