fix(conformance): integrate custody diagnostics with Cave build isolation - #313
Merged
Merged
Conversation
…tion Preserve Chat #311 execution-home routing and classify unsupported installation custody with a bounded diagnostic. Include direct RPC coverage and regenerated executable metadata. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 16, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Source binding and protected validation require final human review.
Pull request overview
This PR integrates custody diagnostics with Cave build isolation while preserving existing behavior.
Changes:
- Adds unsupported-custody classification and coverage.
- Propagates diagnostics through RPC and producer paths.
- Refreshes conformance metadata, documentation, and workflow pins.
File summaries
| File | Description |
|---|---|
src/phase1-conformance-lock.test.ts |
Updates authority expectations. |
src/native-preflight-diagnostics.test.ts |
Adds RPC and boundary coverage. |
src-tauri/src/keyring.rs |
Implements custody classification and Rust coverage. |
scripts/phase1-schema-v2-producer.mjs |
Maps and publishes the new diagnostic. |
phase1-conformance.lock.json |
Refreshes locked source metadata. |
docs/phase1-conformance.md |
Documents diagnostics and refreshed hashes. |
.github/workflows/client-v1-conformance.yml |
Refreshes executable integrity pins. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 18, 2026
BunsDev
added a commit
that referenced
this pull request
Sep 18, 2026
The job is capped at 20 minutes and needs 18 to 20, so it dies on the cap and GitHub reports the overrun as a cancellation, which reads as a flake. It has taken out PR #313 three times and main twice, always after every assertion passed, in the final cargo check step. Raise the cap to 30. Carries every governed digest that moves with this commit. ci.yml is tracked in harnessAuthority.files, so its blob and SHA-256 advance in the lock and in the test's literal copy. Also refreshes three production deltas. Cargo.toml, Cargo.lock and keyring.rs changed in #322 without a repin, which stayed invisible while the authority still pointed at an older commit and the deltas were verified against that older tree. Advancing the authority surfaces the drift, so their digests move here rather than in the repin. Refs #324
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current reviewed head:
1e491f6a671048a7bd4e346d9e86be4eb284720c, integrating merged #312 mainf21953f1326b48787d7bc0362fb9a3055b886863. The integration changes onlye2e/app.tauri-mock.spec.ts; all 36 E2E tests passed. Executable and binding bytes remain unchanged. The verified authority path now passes through157aa554bf908a2b1c396692b490f6cfa4d4a5abto signed executable sourceaa4d33004c59202cae70e3fc5a56a70cdf451dac. Reviewed tree equals the merge result against the new main. Fresh exact-head CI is required.Integrates #307's bounded installation-custody diagnostic on top of merged #311, preserving the Cave build HOME repair. A custody implementation that inherits the default installation method now reports
installation_custody_unsupportedin conformance builds; an unavailable secure store retains its separate code. Ordinary builds retain existing behavior.Adds the missing framed RPC response test, refreshes executable workflow pins, and binds the reviewed combined source
aa4d33004c59202cae70e3fc5a56a70cdf451dac(tree378e977dc2a3d49cc5f97d1740a1a0fdbda6ee75). The frozen candidate and counterpart inputs remain unchanged. Supersedes the conflicted integration in #307 while preserving its original branch and worktree.Validation: normal suite passed 1,255 tests with 63 skips in a serial run; the parallel run encountered three 5-second PowerShell compilation timeouts, and all 17 associated checks passed serially with unchanged timeouts. Targeted combined runtime tests passed (48 TypeScript and one Rust custody test). Typecheck, lint, Rust formatting, and Clippy across all targets/features with warnings denied passed. Independent review verified the source signature, all 25 governed files, 10 production deltas, 12 explicit goldens, and final binding anchors. Heavy suite passed 909 tests with 35 skips (2,164 passing tests across normal and heavy suites).
This adds diagnostic classification; it does not establish the cause of the historical Windows failure or claim protected success. Current protected run 35146928092 validates the preceding Chat #311 / SDK #293 binding. A further SDK binding and protected run are required before accepting evidence from this producer. Normal merge required to retain signed executable-source ancestry.