OpenConceptLab/ocl_issues#2519 | retired_reason in concept/mapping and concept locales#875
Open
snyaggarwal wants to merge 2 commits into
Open
OpenConceptLab/ocl_issues#2519 | retired_reason in concept/mapping and concept locales#875snyaggarwal wants to merge 2 commits into
snyaggarwal wants to merge 2 commits into
Conversation
29 tasks
29 tasks
filiperochalopes
approved these changes
May 26, 2026
Contributor
filiperochalopes
left a comment
filiperochalopes
left a comment
There was a problem hiding this comment.
concept description and mapping were not in the initial plan, but it looks good for standardizing.
Contributor
|
@snyaggarwal please wait for @paynejd 's review |
Contributor
|
@snyaggarwal might be useful to have codex reviewer implemented in your side as well https://developers.openai.com/codex/app/review to have it's feedback in your PR's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Ref OpenConceptLab/ocl_issues#2519
Summary
retire_reasoninconcept,mapping,concept.names[],concept.descriptions[]retire_reasonis optionally set when retiring resource and copied along with future updates on it if the resource is still retiredupdate_commentonconceptandmappingis auto set when retiring (no chnage)retire_reasonis set to None