CLI extraction#71
Closed
mtmail wants to merge 7 commits into
Closed
Conversation
Strip the geocoding library from this repo (now lives in the upstream `opencage` package on PyPI) and keep only the CLI. Rename the internal Python module from `opencage` to `opencage_cli` to avoid colliding with the library's import name. The `opencage` console script and CLI flags are unchanged. Reset distribution version to 1.0.0.
Vendor `query_for_reverse_geocoding` and `floatify_latlng` (plus the `_float_if_float` helper they call) into `opencage_cli/_helpers.py` so the CLI no longer reaches into `opencage.geocoder`'s private API across package boundaries. Also: delete the pre-CLI `examples/batch.py` library demo and its README reference, fix the `--retries` help text + README to say "default 10" (matching the actual code default), drop the stray `test/fixtures/cli/output.csv2` artifact, and update the Vagrantfile synced folder path from `python-opencage-geocoder` to `opencage-cli`.
Move `query_for_reverse_geocoding`, `floatify_latlng` and the `_float_if_float` helper from `opencage_cli/_helpers.py` onto `OpenCageBatchGeocoder` as private methods, and delete the now-empty helpers module.
Extract CLI into standalone opencage-cli package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.