fix: avoid blocking SMD cache during update - #122
Merged
Conversation
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the
PopulateNodesmethod inSMDclient.goto improve thread safety and atomicity of updates, ensuring that cached lookups and modifications are not blocked by slow network operations. Additionally, a new performance test is added to verify that cache operations remain non-blocking during slow refreshes.Thread safety and atomicity improvements:
PopulateNodesto build new maps (nextNodes,nextIPToXname, etc.) off-lock, and only acquire the write lock briefly to atomically swap in the new state, preventing cache lookups from being blocked by network I/O. [1] [2]Testing enhancements:
TestPopulateNodesBlockedRefreshDoesNotBlockCachedOperations, to ensure that cached methods likeIDfromIPandAddWGIPremain responsive even whenPopulateNodesis blocked on a network call.Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change
For more info, see Contributing Guidelines.