Include extra CloudKit fields in TLK share signature checks - #34
Open
thesacredmoocow wants to merge 1 commit into
Open
Include extra CloudKit fields in TLK share signature checks#34thesacredmoocow wants to merge 1 commit into
thesacredmoocow wants to merge 1 commit into
Conversation
Apple now appends fields such as tlkOwnershipProof to CKKSTLKShare dataForSigning. Verifying only the original fields fails Manatee unwrap and blocks iCloud Messages sync.
4 tasks
|
I hit this while building a read-only Find My path, and this PR fixes it better than the one I was preparing :D. In particular, dispatching on the field's declared CloudKit type is better than what I had. One request: could this keep propagating a share whose signature does not verify, rather than warn! + continue ? The silent skip is what made this so difficult to find. Happy to send that as a follow-up if you'd rather keep this PR as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tlkOwnershipProof) when verifying Manateetlksharesignatures, matching Apple'sCKKSTLKShare dataForSigning:.Test plan
Signature verification failed