You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR modernises the BioSimSpace build system by switching to pixi for environment creation/maintenance and rattler-build for building conda packages. This builds on top of the changes to the Sire build system introduced here. In addition, the PR also removes the outdated setup.py installation by introducing the a standard src/BioSimSpace layout using a pyproject.tom. I've also switched to using versioningit for package versioning for consistency with other downstream OpenBioSim packages.
Other unrelated changes are:
Import Process base class through the sub-module __init__ to avoid lazy-loading issues.
Sort imports to avoid Sandpit drift. The refactor to local imports script didn't have a sorting rule, so the imports in the Sandpit are randomised with respect to the core code, despite the rest of the code being identical. This makes it hard to diff the files.
Add support for the recent namd3, which was released in late 2025.
This is the first time the CI will be run, so there might be minor issues to iron out.
I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
I confirm that I have added a test for any new functionality in this pull request: [y]
I confirm that I have added documentation (e.g. a new tutorial page or detailed guide) for any new functionality in this pull request: [y]
I confirm that I have permission to release this code under the GPL3 license: [y]
This is because rattler-build only copies the first entry in the source list to the test directory! For BioSimSpace, we had entries for the python code and test files, since we run black check on the source too. The second entry was silently ignored, hence pytest not being able to find the test files. It's a strange omission, since it's so simple to implement.
One other thing to note is that it looks like test files might be included in the final package, so this would be a good reason not to duplicate the source. I'll check this and consider moving to pre commit, or similar. The legacy black check was essentially a fail-safe.
Finally fixed all the CI issues, what an absolute pain. Turns out the version of rattler-build that comes with their own action had a load of weird bugs. Changing everything to manually install via pixi works, although there are some differences in the way the test environment handles PYTHONPATH, etc. Will merge this tomorrow and move on to the other packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workingenhancementNew feature or request
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernises the BioSimSpace build system by switching to
pixifor environment creation/maintenance andrattler-buildfor building conda packages. This builds on top of the changes to the Sire build system introduced here. In addition, the PR also removes the outdatedsetup.pyinstallation by introducing the a standardsrc/BioSimSpacelayout using apyproject.tom. I've also switched to usingversioningitfor package versioning for consistency with other downstream OpenBioSim packages.Other unrelated changes are:
Processbase class through the sub-module__init__to avoid lazy-loading issues.namd3, which was released in late 2025.This is the first time the CI will be run, so there might be minor issues to iron out.
Closes #358
develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]