fix(install): avoid zsh nomatch error when checking Playwright dirs#49
Open
oopslink wants to merge 1 commit into
Open
fix(install): avoid zsh nomatch error when checking Playwright dirs#49oopslink wants to merge 1 commit into
oopslink wants to merge 1 commit into
Conversation
In zsh, unmatched globs in a for-loop throw a "no matches found" error by default (nomatch option). Combined with `set -euo pipefail`, this caused the installer to exit when no mcp-chrome-for-testing-* dirs existed. Replace glob expansion with `find` to avoid shell glob errors entirely. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the
has_playwright_chrome_for_testing()function ininstall.sh, the original glob pattern could fail whenNOMATCHis enabled inzsh. If no files matched, it would throwzsh: no matches found, causing the installation script to stop.Fix
Replaced the glob pattern with a POSIX-compatible
find + grep -q .approach, ensuring consistent behavior acrossbash,zsh,dash, and other shells.Changed File
install.sh—has_playwright_chrome_for_testing()function.