Fix/critical security vulnerabilities#35
Open
wxiangqi1202-cpu wants to merge 2 commits into
Open
Conversation
…k exposure ## Summary Two design flaws combine to allow any device on the same LAN to fully control the user machine without any authentication. ## Changes ### 1. Default listen address: 0.0.0.0 → 127.0.0.1 (already in previous commit) - ui/server/index.js - ui/server/services/pilotdeckConfig.js - ui/server/cli.js ### 2. DISABLE_LOCAL_AUTH default: true → false (this commit) - ui/server/constants/config.js - Changed from opt-out (must set =0 to enable auth) to opt-in (must set =1 to disable auth) ## Impact - Remote Code Execution via /shell WebSocket - Arbitrary file read/write/delete - API Key theft in plaintext via /api/config/provider - Full project download as ZIP - Git repo manipulation (commit, push, delete branches) - SSRF via /api/config/test-connection ## Reproduction Any device on the same WiFi can access http://<victim-ip>:3001 with zero credentials. See SECURITY_REPORT.md for full details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复电脑安装后PilotDeck后，通过任何同一个wift下的设备读取bug