Fix streamed Chat Completions aggregation#654
Draft
taking-lying-flat wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stream_optionsfor compatible gateways that reject itstream: falseand a narrow fallback when streaming is explicitly unsupportedprotocol,stream, andstream_optionscontrols from leaking into incompatible request pathsRoot cause
The existing Chat Completions branches called
client.chat.completions.create()without streaming and then assumed a complete response atresponse.choices[0].message. Gateways that require streaming rejected long-running requests. Simply settingstream: truewas also insufficient because it returned an iterator that the existing timeline, token accounting, and tool-call deserialization code could not consume.Impact
Chat Completions now use streaming transport by default while downstream ChatDev code still receives an aggregated completion. Token tracking, timeline handling, and tool-call parsing keep their existing interfaces. Legacy non-streaming gateways can opt out with
params.stream: false, and explicit unsupported-streaming responses downgrade narrowly without masking authentication, quota, timeout, or server failures.