fix: cap ThreadPoolExecutor max_workers to prevent resource exhaustion#620
Open
hobostay wants to merge 1 commit into
Open
fix: cap ThreadPoolExecutor max_workers to prevent resource exhaustion#620hobostay wants to merge 1 commit into
hobostay wants to merge 1 commit into
Conversation
Previously, max_workers was set to len(items), which could create an unbounded number of threads if the input list is large. This caps the thread pool to a reasonable default (min of item count and cpu_count+4, up to 32), following the standard library pattern. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThreadPoolExecutor(max_workers=len(items))tomin(len(items), MAX_WORKERS)inworkflow/executor/parallel_executor.pyBug Details
In
workflow/executor/parallel_executor.py(line 106), the parallel executor creates a thread pool withmax_workers=len(items):If a workflow contains many parallel nodes, this could create thousands of threads, causing:
Python's own
ThreadPoolExecutordefault ismin(32, os.cpu_count() + 4), which is a well-tested heuristic.Fix
Added a
MAX_WORKERSconstant following the standard library pattern and capped the pool size:Test plan
🤖 Generated with Claude Code