fix(security): replace yaml.load(FullLoader) with yaml.safe_load#619
Open
hobostay wants to merge 1 commit into
Open
fix(security): replace yaml.load(FullLoader) with yaml.safe_load#619hobostay wants to merge 1 commit into
hobostay wants to merge 1 commit into
Conversation
yaml.load with FullLoader can still instantiate arbitrary Python objects through YAML tags like !!python/object, which enables remote code execution when loading untrusted YAML files. yaml.safe_load only supports standard YAML tags and is safe. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yaml.load(f, Loader=yaml.FullLoader)withyaml.safe_load(f)inutils/io_utils.pyandentity/config_loader.pyyaml.safe_load(e.g.server/services/workflow_storage.py,entity/configs/node/skills.py,runtime/node/agent/skills/manager.py)FullLoaderVulnerability Details
yaml.FullLoaderstill supports certain Python object tags (like!!python/object), which can be exploited for arbitrary code execution when loading YAML from untrusted sources.yaml.safe_loadrestricts loading to standard YAML tags only, which is the recommended safe default.The other YAML loading sites in this codebase already use
yaml.safe_load. These two were overlooked.Files Changed
utils/io_utils.py:6—yaml.load(f, Loader=yaml.FullLoader)→yaml.safe_load(f)entity/config_loader.py:30—yaml.load(handle, Loader=yaml.FullLoader)→yaml.safe_load(handle)Test plan
🤖 Generated with Claude Code