ci: run pull-request checks on every base branch - #80
Merged
Conversation
PR #78 targets codex/promote-capture-beta, so the branches: [main] filter on pull_request matched almost nothing. The pull request reports mergeStateStatus CLEAN with 1 check instead of the full set, which makes an unverified change look the same as a passing one. Remove the base-branch filter from the three pull_request triggers. The push trigger keeps branches: [main]. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
PR #78 targets
codex/promote-capture-beta, notmain. Thepull_requesttriggers here are filtered tobranches: [main], so the stacked pull request ran 1 check instead of the full set, while reportingmergeStateStatus: CLEAN.An unverified pull request is indistinguishable from a passing one in the UI and in
gh pr view.codex/promote-capture-betacodex/production-evidence-contractcodex/push-json-contractopenadapt-flow#372 gets full CI because Flow's
ci.ymlcarries no base filter. That confirms the mechanism.The change
Remove the base-branch filter from the
test,codeql, anddependency-reviewpull_requesttriggers. Thepushtrigger keepsbranches: [main].Companion change: OpenAdaptAI/openadapt-evals#288.
🤖 Generated with Claude Code