Skip to content

Revert "fix(go): fix Go client to normalize request header keys using… - #24792

Closed
wing328 wants to merge 1 commit into
masterfrom
test-go-auth
Closed

Revert "fix(go): fix Go client to normalize request header keys using…#24792
wing328 wants to merge 1 commit into
masterfrom
test-go-auth

Conversation

@wing328

@wing328 wing328 commented Aug 27, 2026

Copy link
Copy Markdown
Member

… Header.Set (#24766)"

This reverts commit 091a02f.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Reverts the Go client header normalization fix so request header keys are no longer canonicalized by Header.Set. The client now assigns header values directly, preserving key casing like api_key.

  • Go client template and all generated Go samples switch back to headers[h] = []string{v}.
  • Auth tests updated to expect lowercase api_key in dumped request headers.
  • Go module version lowered from 1.25 to 1.22, removing now-unused go.sum entries from associated samples.

Written for commit c0f11c5. Summary will update on new commits.

Review in cubic

@wing328 wing328 closed this Aug 27, 2026
@wing328
wing328 deleted the test-go-auth branch August 27, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant