Neokil fix/csharp test type name collision - #24522
Draft
wing328 wants to merge 6 commits into
Draft
Conversation
…tandard library name collisions
When a model class shares a name with a .NET standard library type (e.g.
`Attributes`), the generated `Assert.IsType<Attributes>(model)` call is
ambiguous and fails to compile. Use the fully-qualified type name
`{{packageName}}.{{modelPackage}}.{{{.}}}` for model return types so the
generated test code is unambiguous regardless of model naming.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…generichost/api_test.mustache Co-authored-by: Christopher Molin <28791817+Chrimle@users.noreply.github.com>
…com/Neokil/openapi-generator into Neokil-fix/csharp-test-type-name-collision
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Qualifies model types in generated C# Generic Host API tests to avoid collisions with .NET types. Uses fully qualified model names in Assert.IsType checks so tests compile when model names match framework types.
csharp/libraries/generichost/api_test.mustache,Assert.IsType<>now prefixes model return types with{{packageName}}.{{modelPackage}}(only whenisModel) to disambiguate.latest,net8,net10,net4.7, andnet4.8to apply the change.Written for commit f07e31e. Summary will update on new commits.