fix(cpp-httplib-server): handle missing optional JSON properties#24010
Open
Dharshika-11 wants to merge 1 commit into
Open
fix(cpp-httplib-server): handle missing optional JSON properties#24010Dharshika-11 wants to merge 1 commit into
Dharshika-11 wants to merge 1 commit into
Conversation
Member
|
https://github.com/OpenAPITools/openapi-generator/actions/runs/27406589837/job/81020413323?pr=24010 please follow step 3 in the PR checklist to update the samples so as to address the build failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23991
This fixes a crash in cpp-httplib-server generator when optional JSON properties
are missing in the request payload.
Previously, NLOHMANN_DEFINE_TYPE_INTRUSIVE was used which does not safely handle
missing fields.
Now replaced with custom to_json/from_json using:
Summary by cubic
Prevents crashes in the
cpp-httplib-servergenerator when request JSON omits optional fields by switching to explicitto_json/from_jsonhandling. Generated servers now safely ignore missing optional properties.NLOHMANN_DEFINE_TYPE_INTRUSIVEwith friendto_json/from_jsonin model headers.j.at(...).get_to(...).j.contains(...)and null check beforeget_to(...).Written for commit 3eeffcd. Summary will update on new commits.