Skip to content

fix: Change Dart Serializer for MapBuilder to be nullable#23460

Open
jdk-21 wants to merge 2 commits intoOpenAPITools:masterfrom
jdk-21:patch-1
Open

fix: Change Dart Serializer for MapBuilder to be nullable#23460
jdk-21 wants to merge 2 commits intoOpenAPITools:masterfrom
jdk-21:patch-1

Conversation

@jdk-21
Copy link
Copy Markdown

@jdk-21 jdk-21 commented Apr 7, 2026

I tried using the generator cli for the Jellyfin OpenAPI spec in Dart, but when serializing a BuiltMap<String, String?> which had null as a value I got an error:

Error: Deserializing to 'DisplayPreferencesDto' failed due to: Deserializing to 'BuiltMap<String, String?>' failed due to: type 'Null' is not a subtype of type 'String' of 'value'

While investigating this issue I found this type mismatch. I don't have experience with this template language, but this should fix the issue.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard @josh-burton @amondnet


Summary by cubic

Fix the Dart built_value serializer to emit nullable MapBuilder types for maps with nullable values, preventing errors when deserializing BuiltMap<String, T?>.

  • Bug Fixes
    • Update serializers.mustache to use MapBuilder<String, {{dataType}}?> when isNullable is true, matching FullType.nullable(...); refresh the petstore_client_lib_fake sample to MapBuilder<String, JsonObject?> to confirm the fix in dio + built_value clients.

Written for commit 3e855e5. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 7, 2026

thanks for the pr

please follow step 3 to update the samples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants