fix: Change Dart Serializer for MapBuilder to be nullable#23460
Open
jdk-21 wants to merge 2 commits intoOpenAPITools:masterfrom
Open
fix: Change Dart Serializer for MapBuilder to be nullable#23460jdk-21 wants to merge 2 commits intoOpenAPITools:masterfrom
jdk-21 wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
Member
|
thanks for the pr please follow step 3 to update the samples |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried using the generator cli for the Jellyfin OpenAPI spec in Dart, but when serializing a BuiltMap<String, String?> which had null as a value I got an error:
While investigating this issue I found this type mismatch. I don't have experience with this template language, but this should fix the issue.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@jaumard @josh-burton @amondnet
Summary by cubic
Fix the Dart
built_valueserializer to emit nullableMapBuildertypes for maps with nullable values, preventing errors when deserializingBuiltMap<String, T?>.serializers.mustacheto useMapBuilder<String, {{dataType}}?>whenisNullableis true, matchingFullType.nullable(...); refresh thepetstore_client_lib_fakesample toMapBuilder<String, JsonObject?>to confirm the fix indio+built_valueclients.Written for commit 3e855e5. Summary will update on new commits.