Skip to content

Comments

[PHP] Always prefer host config over static servers from OpenAPI declaration#23017

Open
stollr wants to merge 1 commit intoOpenAPITools:masterfrom
stollr:fix-23016-operation-host
Open

[PHP] Always prefer host config over static servers from OpenAPI declaration#23017
stollr wants to merge 1 commit intoOpenAPITools:masterfrom
stollr:fix-23016-operation-host

Conversation

@stollr
Copy link

@stollr stollr commented Feb 20, 2026

This PR fixes the bug described in #23016.

Currently the host in the config object is ignored if an operation declares its own servers in the OpenAPI file, which makes it impossible to override it in the application.

With this change, the host, defined in the config, always has priority over the servers declared in the operation.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)


Summary by cubic

Always use the config host for PHP PSR-18 clients, even when an operation defines its own servers, so apps can override OpenAPI-declared hosts. Fixes #23016.

  • Bug Fixes
    • Use config host if set; only fall back to operation servers when config host is empty, with hostIndex validation.

Written for commit 195abcf. Summary will update on new commits.

…aration

Currently the host in the config object is ignored if an operation declares its own `servers` in the OpenAPI file, which makes it impossible to override it in the application.

Fixes OpenAPITools#23016
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@stollr
Copy link
Author

stollr commented Feb 20, 2026

After looking over the api class behaviour regarding the default hosts config once again, I realize that my solution could be problematic if specific operations have different server declarations than the rest and would lead to backward incompatibility.

So if anybody has an idea to improve this, you are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][PHP] Host config is ignored if operation declares servers in OpenAPI file

1 participant